⚠️ GitHub issue #46499 has been automatically assigned in GitHub to PR creator.

pull_request.types: [labeled] will not work well. We need another approach.

@WillAyd Can we avoid changing the source directory by Meson? Should we use --wrap-mode=nodownload in CI?

Hmm well I think this will prevent the dependencies from being automatically downloaded, but then you will have to have the dependency installed in the CI container some other way, so not sure that is really the fix.

IIUC the error message is coming from tests that belong to bzip2. I think we can avoid running subproject tests if we change:

meson test

to

meson test "arrow*"

Can we disable bundled bzip2 tests entirely?

In general, we don't want to build tests of bundled dependencies. For example:

https://github.com/mesonbuild/wrapdb/blob/c068c1051eaf88b7c00618295846ddd94467b272/subprojects/packagefiles/bzip2/meson.build#L27-L106

It seems that we can't disable tests...

Yep exactly - I can try to upstream a change to the wrapdb, but in its current state you cannot

Though interestingly the bzip2 project has its own CMake and Meson configuration files upstream, and neither of them provide an option to disable tests:

https://github.com/libarchive/bzip2/blob/1ea1ac188ad4b9cb662e3f8314673c63df95a589/CMakeOptions.txt

We can probably start by requesting an option in that project directly

It makes sense. Could you do it?

Sure - see https://gitlab.com/bzip2/bzip2/-/issues/59

It seems that we can use meson test --suite arrow to ignore bzip2 tests.

This is ready.

I'll merge this in a few days if nobody objects it.

No objection. I'll merge this.

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b8c9f76.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.